Skip to content

Change GitHub action condition to display infrastructure changes on pull requests#740

Merged
tjementum merged 2 commits into
mainfrom
pp-395-the-planning-step-in-the-infrastructure-workflow-does-not
Apr 27, 2025
Merged

Change GitHub action condition to display infrastructure changes on pull requests#740
tjementum merged 2 commits into
mainfrom
pp-395-the-planning-step-in-the-infrastructure-workflow-does-not

Conversation

@tjementum
Copy link
Copy Markdown
Member

@tjementum tjementum commented Apr 26, 2025 •
edited
Loading

Summary & Motivation

Fix GitHub Actions workflow issues with deployment to staging environments from pull requests. Previously, two bugs were preventing proper deployment:

  • Fix infrastructure planning step that was failing to run on pull requests with the "Deploy to Staging" label.
  • Fix application code deployment to staging that was blocked when the "Deploy to Staging" label was set on a pull request.

Checklist

  • I have added tests, or done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added the Bug Something isn't working label Apr 26, 2025
@tjementum tjementum self-assigned this Apr 26, 2025
@tjementum tjementum requested a review from a team as a code owner April 26, 2025 23:45
@linear
Copy link
Copy Markdown

linear Bot commented Apr 26, 2025

PP-395 The planning step in the infrastructure workflow does not run on pull requests

@tjementum tjementum moved this to 🏗 In Progress in Kanban board Apr 26, 2025
@tjementum tjementum changed the title Fix planning step in infrastructure workflow to run on pull requests with staging label Fix cloud infrastructure plan step not running correctly on pull requests Apr 26, 2025
@tjementum tjementum changed the title Fix cloud infrastructure plan step not running correctly on pull requests Fix cloud infrastructure plan step for staging to run on pull requests Apr 26, 2025
@tjementum tjementum added the Deploy to Staging Set this label on pull requests to deploy code or infrastructure to the Staging environment label Apr 26, 2025
@tjementum tjementum force-pushed the pp-395-the-planning-step-in-the-infrastructure-workflow-does-not branch from 4b74e97 to 3e6fba2 Compare April 26, 2025 23:52
@tjementum tjementum force-pushed the pp-395-the-planning-step-in-the-infrastructure-workflow-does-not branch from 3c1b330 to 9456649 Compare April 27, 2025 12:01
@tjementum tjementum removed the Deploy to Staging Set this label on pull requests to deploy code or infrastructure to the Staging environment label Apr 27, 2025
@tjementum tjementum changed the title Fix cloud infrastructure plan step for staging to run on pull requests Change GitHub action condition to run and display infrastructure changes on pull requests Apr 27, 2025
@tjementum tjementum changed the title Change GitHub action condition to run and display infrastructure changes on pull requests Change GitHub action condition to display infrastructure changes on pull requests Apr 27, 2025
@tjementum tjementum force-pushed the pp-395-the-planning-step-in-the-infrastructure-workflow-does-not branch from 9456649 to ded3230 Compare April 27, 2025 12:09
@tjementum tjementum added the Deploy to Staging Set this label on pull requests to deploy code or infrastructure to the Staging environment label Apr 27, 2025
@tjementum tjementum force-pushed the pp-395-the-planning-step-in-the-infrastructure-workflow-does-not branch from 9001648 to 001acc3 Compare April 27, 2025 12:33
@tjementum tjementum removed the Deploy to Staging Set this label on pull requests to deploy code or infrastructure to the Staging environment label Apr 27, 2025
@tjementum tjementum force-pushed the pp-395-the-planning-step-in-the-infrastructure-workflow-does-not branch from 001acc3 to 15ba65d Compare April 27, 2025 13:06
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tjementum tjementum merged commit 4f43b87 into main Apr 27, 2025
30 checks passed
@tjementum tjementum deleted the pp-395-the-planning-step-in-the-infrastructure-workflow-does-not branch April 27, 2025 13:11
@github-project-automation github-project-automation Bot moved this from 🏗 In Progress to ✅ Done in Kanban board Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tjementum tjementum

Labels

Bug Something isn't working

Projects

Kanban board
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tjementum